This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer: BPA] Add test for SNMP::IPCountTable thread-safety#59
Open
rkday-pro wants to merge 1 commit into
Open
[Reviewer: BPA] Add test for SNMP::IPCountTable thread-safety#59rkday-pro wants to merge 1 commit into
rkday-pro wants to merge 1 commit into
Conversation
BennettAllen1
self-requested a review
January 9, 2018 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test reproduces the issue you raised in https://github.com/Metaswitch/clearwater-issues/issues/2905, by running two threads which both try to use the table 100,000 times, making the race condition very likely to happen. I'm going to send another PR that tries to fix the problem.